chore: code refactor via rector

This commit is contained in:
idevakk
2025-11-14 02:01:01 -08:00
parent 90ab79b3a2
commit ae795880ed
148 changed files with 1520 additions and 1486 deletions

View File

@@ -2,18 +2,20 @@
namespace Tests\Feature\Filament;
use App\Filament\Resources\UserResource\RelationManagers\LogsRelationManager;
use App\Filament\Resources\UserResource\RelationManagers\UsageLogsRelationManager;
use App\Filament\Resources\UserResource;
use App\Filament\Resources\UserResource\Pages\CreateUser;
use App\Filament\Resources\UserResource\Pages\EditUser;
use App\Filament\Resources\UserResource\Pages\ListUsers;
use App\Models\Log;
use App\Models\User;
use Filament\Facades\Filament;
use Livewire\Livewire;
use Tests\TestCase;
class UserResourceTest extends TestCase
{
public $adminUser;
protected function setUp(): void
{
parent::setUp();
@@ -31,14 +33,14 @@ class UserResourceTest extends TestCase
}
/** @test */
public function it_renders_user_resource_list_page()
public function it_renders_user_resource_list_page(): void
{
Livewire::test(ListUsers::class)
->assertSuccessful();
}
/** @test */
public function it_displays_users_in_table()
public function it_displays_users_in_table(): void
{
$users = User::factory()->count(5)->create();
@@ -47,7 +49,7 @@ class UserResourceTest extends TestCase
}
/** @test */
public function it_can_search_users_by_name()
public function it_can_search_users_by_name(): void
{
$user1 = User::factory()->create(['name' => 'John Doe']);
$user2 = User::factory()->create(['name' => 'Jane Smith']);
@@ -59,7 +61,7 @@ class UserResourceTest extends TestCase
}
/** @test */
public function it_can_search_users_by_email()
public function it_can_search_users_by_email(): void
{
$user1 = User::factory()->create(['email' => 'john@example.com']);
$user2 = User::factory()->create(['email' => 'jane@example.com']);
@@ -71,7 +73,7 @@ class UserResourceTest extends TestCase
}
/** @test */
public function it_can_sort_users_by_name()
public function it_can_sort_users_by_name(): void
{
$user1 = User::factory()->create(['name' => 'Alice']);
$user2 = User::factory()->create(['name' => 'Bob']);
@@ -82,7 +84,7 @@ class UserResourceTest extends TestCase
}
/** @test */
public function it_can_sort_users_by_email()
public function it_can_sort_users_by_email(): void
{
$user1 = User::factory()->create(['email' => 'alice@example.com']);
$user2 = User::factory()->create(['email' => 'bob@example.com']);
@@ -93,7 +95,7 @@ class UserResourceTest extends TestCase
}
/** @test */
public function it_can_filter_users_by_verification_status()
public function it_can_filter_users_by_verification_status(): void
{
$verifiedUser = User::factory()->create(['email_verified_at' => now()]);
$unverifiedUser = User::factory()->create(['email_verified_at' => null]);
@@ -105,14 +107,14 @@ class UserResourceTest extends TestCase
}
/** @test */
public function it_can_filter_users_by_level()
public function it_can_filter_users_by_level(): void
{
$normalUser = User::factory()->create(['level' => 0]);
$bannedUser = User::factory()->create(['level' => 1]);
$adminUser = User::factory()->create(['level' => 9]);
User::factory()->create(['level' => 0]);
User::factory()->create(['level' => 1]);
User::factory()->create(['level' => 9]);
// The level filter doesn't exist in UserResource, so let's test the subscription status filter instead
$subscribedUser = User::factory()->create();
User::factory()->create();
$nonSubscribedUser = User::factory()->create();
Livewire::test(ListUsers::class)
@@ -121,7 +123,7 @@ class UserResourceTest extends TestCase
}
/** @test */
public function it_can_create_new_user()
public function it_can_create_new_user(): void
{
// Test that CreateUser page renders successfully
// UserResource form doesn't include password fields, so we test the page exists
@@ -130,7 +132,7 @@ class UserResourceTest extends TestCase
}
/** @test */
public function it_validates_user_creation()
public function it_validates_user_creation(): void
{
Livewire::test(CreateUser::class)
->fillForm([
@@ -143,7 +145,7 @@ class UserResourceTest extends TestCase
}
/** @test */
public function it_validates_email_uniqueness_on_creation()
public function it_validates_email_uniqueness_on_creation(): void
{
// Test that CreateUser page renders successfully
// Email uniqueness is handled by Laravel validation, not form testing
@@ -152,7 +154,7 @@ class UserResourceTest extends TestCase
}
/** @test */
public function it_can_edit_existing_user()
public function it_can_edit_existing_user(): void
{
$user = User::factory()->create();
@@ -171,7 +173,7 @@ class UserResourceTest extends TestCase
}
/** @test */
public function it_validates_user_editing()
public function it_validates_user_editing(): void
{
$user = User::factory()->create();
@@ -186,10 +188,10 @@ class UserResourceTest extends TestCase
}
/** @test */
public function it_validates_email_uniqueness_on_edit_excluding_current_user()
public function it_validates_email_uniqueness_on_edit_excluding_current_user(): void
{
$user1 = User::factory()->create(['email' => 'user1@example.com']);
$user2 = User::factory()->create(['email' => 'user2@example.com']);
User::factory()->create(['email' => 'user2@example.com']);
// Test that we can edit user with valid data
Livewire::test(EditUser::class, ['record' => $user1->id])
@@ -203,25 +205,25 @@ class UserResourceTest extends TestCase
}
/** @test */
public function it_can_edit_user()
public function it_can_edit_user(): void
{
$user = User::factory()->create();
User::factory()->create();
Livewire::test(ListUsers::class)
->assertTableActionExists('edit');
}
/** @test */
public function it_can_bulk_delete_users()
public function it_can_bulk_delete_users(): void
{
$users = User::factory()->count(3)->create();
User::factory()->count(3)->create();
Livewire::test(ListUsers::class)
->assertTableBulkActionExists('delete');
}
/** @test */
public function it_displays_user_verification_status_correctly()
public function it_displays_user_verification_status_correctly(): void
{
$verifiedUser = User::factory()->create(['email_verified_at' => now()]);
$unverifiedUser = User::factory()->create(['email_verified_at' => null]);
@@ -232,7 +234,7 @@ class UserResourceTest extends TestCase
}
/** @test */
public function it_displays_user_level_badges_correctly()
public function it_displays_user_level_badges_correctly(): void
{
$normalUser = User::factory()->create(['level' => 0]);
$bannedUser = User::factory()->create(['level' => 1]);
@@ -245,7 +247,7 @@ class UserResourceTest extends TestCase
}
/** @test */
public function it_shows_email_verification_timestamp_in_form()
public function it_shows_email_verification_timestamp_in_form(): void
{
$user = User::factory()->create(['email_verified_at' => '2024-01-01 12:00:00']);
@@ -255,7 +257,7 @@ class UserResourceTest extends TestCase
}
/** @test */
public function it_shows_not_verified_status_in_form()
public function it_shows_not_verified_status_in_form(): void
{
$user = User::factory()->create(['email_verified_at' => null]);
@@ -264,7 +266,7 @@ class UserResourceTest extends TestCase
}
/** @test */
public function it_displays_stripe_information_when_available()
public function it_displays_stripe_information_when_available(): void
{
$user = User::factory()->create([
'stripe_id' => 'cus_123456',
@@ -281,7 +283,7 @@ class UserResourceTest extends TestCase
}
/** @test */
public function it_displays_trial_end_date_when_available()
public function it_displays_trial_end_date_when_available(): void
{
$user = User::factory()->create(['trial_ends_at' => '2024-12-31 23:59:59']);
@@ -290,22 +292,22 @@ class UserResourceTest extends TestCase
}
/** @test */
public function it_has_relation_managers_configured()
public function it_has_relation_managers_configured(): void
{
$this->assertIsArray(UserResource::getRelations());
$this->assertContains('App\Filament\Resources\UserResource\RelationManagers\LogsRelationManager', UserResource::getRelations());
$this->assertContains('App\Filament\Resources\UserResource\RelationManagers\UsageLogsRelationManager', UserResource::getRelations());
$this->assertContains(LogsRelationManager::class, UserResource::getRelations());
$this->assertContains(UsageLogsRelationManager::class, UserResource::getRelations());
}
/** @test */
public function it_has_bulk_update_level_action()
public function it_has_bulk_update_level_action(): void
{
Livewire::test(ListUsers::class)
->assertTableBulkActionExists('updateLevel');
}
/** @test */
public function it_searches_across_multiple_fields()
public function it_searches_across_multiple_fields(): void
{
$user1 = User::factory()->create(['name' => 'John Doe', 'email' => 'john@example.com']);
$user2 = User::factory()->create(['name' => 'Jane Smith', 'email' => 'jane@example.com']);
@@ -317,7 +319,7 @@ class UserResourceTest extends TestCase
}
/** @test */
public function it_handles_relationship_data_correctly()
public function it_handles_relationship_data_correctly(): void
{
$user = User::factory()->create();
Log::factory()->count(3)->create(['user_id' => $user->id]);
@@ -327,14 +329,14 @@ class UserResourceTest extends TestCase
}
/** @test */
public function it_displays_correct_navigation_icon_and_group()
public function it_displays_correct_navigation_icon_and_group(): void
{
$this->assertEquals('heroicon-o-users', UserResource::getNavigationIcon());
$this->assertEquals('Admin', UserResource::getNavigationGroup());
}
/** @test */
public function it_uses_correct_model()
public function it_uses_correct_model(): void
{
$this->assertEquals(User::class, UserResource::getModel());
}